Fixing details #238
Closed
Fixing details #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Oct 23, 2015
yceruto
commented
- Fixing imports (unused or missing).
- Adding type hinting.
- Fixed variable definition.
Contributor
There was a problem hiding this comment.
@yceruto, I think it's better to use a FQCN here.
Member
Author
There was a problem hiding this comment.
@voronkovich why it's better to use a FQCN here? please, could you explain a little more.
Contributor
There was a problem hiding this comment.
@yceruto, using FQCN doesn't require to import User class.
Member
Author
defining variable using the User FQCN in comments Revert "using the User FQCN in comments" This reverts commit 8af0353.
Member
|
Thanks @yceruto. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.